MINOR: Upgrade Spotbugs to 4.9.1 #20294
Merged
+174
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add exclusions for new warnings to allow this upgrade.
github-actions
bot
added
triage
chia7712
reviewed
Aug 4, 2025
| @@ -550,4 +550,173 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read | |||
| <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/> | |||
| </Match> | |||
|
|
|||
| <Match> | |||
There was a problem hiding this comment.
open https://issues.apache.org/jira/browse/KAFKA-19575 to revisit them later.
build.gradle
Outdated
| @@ -37,7 +37,7 @@ plugins { | |||
| id 'org.nosphere.apache.rat' version "0.8.1" | |||
| id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}" | |||
|
|
|||
| id "com.github.spotbugs" version '6.0.25' apply false | |||
| id "com.github.spotbugs" version '6.2.2' apply false | |||
There was a problem hiding this comment.
the latest version is 6.2.3. could you please give it a try
There was a problem hiding this comment.
Yes, bumped to that one
| @@ -123,7 +123,7 @@ versions += [ | |||
| scoverage: "2.0.11", | |||
| slf4j: "1.7.36", | |||
| snappy: "1.1.10.7", | |||
| spotbugs: "4.8.6", | |||
| spotbugs: "4.9.1", | |||
There was a problem hiding this comment.
ditto. If there is a strong reason to use 4.9.1 instead of 4.9.3, could you please add comments explaining it?
There was a problem hiding this comment.
Added a note explaining why 4.9.2 and 4.9.3 don't work.
chia7712
approved these changes
Aug 4, 2025
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Aug 6, 2025
Add exclusions for new warnings to allow this upgrade. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exclusions for new warnings to allow this upgrade.
Reviewers: Chia-Ping Tsai [email protected]