bugfix: undo log table name dynamic derivation #7747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 29, 2025 20:38
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7747 +/- ##
============================================
+ Coverage 66.01% 66.17% +0.16%
Complexity 992 992
============================================
Files 1323 1323
Lines 50137 50140 +3
Branches 5922 5922
============================================
+ Hits 33096 33180 +84
+ Misses 14141 14048 -93
- Partials 2900 2912 +12
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
YvCeung
reviewed
Oct 30, 2025
YvCeung
approved these changes
Oct 30, 2025
YvCeung
reviewed
Oct 30, 2025
...c/test/java/org/apache/seata/rm/datasource/undo/postgresql/PostgresqlUndoLogManagerTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
October 30, 2025 20:59
|
LGTM |
YvCeung
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
PostgreSQL's rollback log table names are hardcoded, which is inconvenient for users to configure via configuration files. Configuring them can lead to failed insert operations or abnormal behavior.
This pull request retrieves the corresponding rollback log table name from the user's configuration file and updates the insert SQL statements in
PostgresqlUndoLogManager. If the user hasn't configured it, the default name version is rolled back.This issue isn't limited to PostgreSQL; it also occurs in Oracle, Oscar, and Kingbase. I've addressed this issue and added unit tests to verify its correctness.
Ⅱ. Does this pull request fix one issue?
fixes #7581
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
mvn clean test
Ⅴ. Special notes for reviews