Skip to content

Conversation

Bughue
Copy link
Contributor

@Bughue Bughue commented Sep 30, 2025

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

fixes #7558

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Bughue Bughue changed the title test : fix old version connect fail test : fix old version connect timeout Sep 30, 2025
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.41%. Comparing base (3495837) to head (51fa071).
⚠️ Report is 2 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7679      +/-   ##
============================================
+ Coverage     61.28%   61.41%   +0.12%     
  Complexity      666      666              
============================================
  Files          1314     1314              
  Lines         49817    49817              
  Branches       5858     5858              
============================================
+ Hits          30532    30593      +61     
+ Misses        16545    16479      -66     
- Partials       2740     2745       +5     
Files with missing lines Coverage Δ
...che/seata/core/rpc/netty/NettyServerBootstrap.java 74.22% <100.00%> (ø)

... and 11 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bughue Bughue changed the title test : fix old version connect timeout test: fix old version connect timeout Sep 30, 2025
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 2.6.0 milestone Sep 30, 2025
@slievrly slievrly merged commit e06d364 into apache:2.x Sep 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failure: io.seata.MockTest.testRollback Fails with RPC Timeout
2 participants