Skip to content

Conversation

@YvCeung
Copy link
Contributor

@YvCeung YvCeung commented Sep 6, 2025

Ⅰ. Describe what this PR did

fixed the issue where integer values in YAML configuration files could not be retrieved from the configuration center(eg : nacos)

Ⅱ. Does this pull request fix one issue?

fix #7582

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.03%. Comparing base (d859fef) to head (501bc8a).
⚠️ Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...g/apache/seata/config/processor/ProcessorYaml.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7624      +/-   ##
============================================
+ Coverage     61.02%   61.03%   +0.01%     
  Complexity      666      666              
============================================
  Files          1316     1316              
  Lines         49800    49804       +4     
  Branches       5855     5855              
============================================
+ Hits          30389    30400      +11     
+ Misses        16706    16697       -9     
- Partials       2705     2707       +2     
Files with missing lines Coverage Δ
...g/apache/seata/config/processor/ProcessorYaml.java 88.88% <80.00%> (-11.12%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.6.0 milestone Sep 8, 2025
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/config config module labels Sep 8, 2025
@funky-eyes funky-eyes merged commit 4a03548 into apache:2.x Sep 8, 2025
10 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/config config module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YAML configuration with integer values cannot be read correctly in Seata

2 participants