Skip to content

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Sep 2, 2025

Ⅰ. Describe what this PR did

Refactor Alibaba Dubbo and HSF

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 72.54902% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.30%. Comparing base (3495837) to head (0b1e2c4).
⚠️ Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
...alibaba/AlibabaDubboTransactionProviderFilter.java 75.00% 4 Missing and 6 partials ⚠️
...alibaba/AlibabaDubboTransactionConsumerFilter.java 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7617      +/-   ##
============================================
+ Coverage     61.28%   61.30%   +0.01%     
- Complexity      666      680      +14     
============================================
  Files          1314     1314              
  Lines         49817    49847      +30     
  Branches       5858     5858              
============================================
+ Hits          30532    30557      +25     
- Misses        16545    16548       +3     
- Partials       2740     2742       +2     
Files with missing lines Coverage Δ
...alibaba/AlibabaDubboTransactionConsumerFilter.java 60.86% <63.63%> (-3.42%) ⬇️
...alibaba/AlibabaDubboTransactionProviderFilter.java 78.94% <75.00%> (+28.94%) ⬆️

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.6.0 milestone Sep 15, 2025
@funky-eyes funky-eyes added type: refactor refactor module module/integration integration module labels Sep 15, 2025
@funky-eyes
Copy link
Contributor

@slievrly slievrly merged commit 06ec3fe into apache:2.x Oct 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/integration integration module type: refactor refactor module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants