bugfix: Add scheduled tasks to clean up futures #7333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
May 6, 2025
| mergeSendExecutorService.shutdown(); | ||
| } | ||
|
|
||
| futures.clear(); |
There was a problem hiding this comment.
Why is it necessary to clean up these maps? When a RemotingClient executes the destroy method, this instance should no longer be used. In theory, it should be garbage collected, or the application is shutting down.
There was a problem hiding this comment.
Yes. manually clearing the maps is indeed unnecessary.I have removed it.
funky-eyes
reviewed
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Use scheduled tasks to detect whether futures have timeout information before sending messages. If there is, clear it to avoid memory leaks
Ⅱ. Does this pull request fix one issue?
fixes #5283
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews