Skip to content

Conversation

@slievrly
Copy link
Member

@slievrly slievrly commented Mar 18, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add license header

https://lists.apache.org/thread/k06snqhvjx37y0f5dq8gv9oxwvgo7w9f

Ⅱ. Does this pull request fix one issue?

fixes #7231

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title [WIP]optimize: add license header optimize: add license header Mar 18, 2025
@slievrly slievrly added this to the 2.4.0 milestone Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.98%. Comparing base (13509de) to head (383ab68).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7232      +/-   ##
============================================
- Coverage     53.99%   53.98%   -0.01%     
+ Complexity     7205     7204       -1     
============================================
  Files          1173     1173              
  Lines         41796    41796              
  Branches       4906     4906              
============================================
- Hits          22566    22565       -1     
  Misses        17099    17099              
- Partials       2131     2132       +1     

see 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi
Copy link
Member

@slievrly Please add this PR in change log file

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 0ad7f3d into apache:2.x Mar 24, 2025
6 checks passed
slievrly added a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Process

Development

Successfully merging this pull request may close these issues.

Add the license header to the source code files.

3 participants