Skip to content

Conversation

@renliangyu857
Copy link
Contributor

…te executor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5005

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Merging #5033 (e8d1d02) into develop (9e6a3b5) will increase coverage by 0.17%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5033      +/-   ##
=============================================
+ Coverage      49.06%   49.24%   +0.17%     
- Complexity      4092     4111      +19     
=============================================
  Files            733      733              
  Lines          26004    26005       +1     
  Branches        3211     3212       +1     
=============================================
+ Hits           12759    12805      +46     
+ Misses         11887    11839      -48     
- Partials        1358     1361       +3     
Impacted Files Coverage Δ
...ec/mysql/MySQLInsertOnDuplicateUpdateExecutor.java 30.97% <50.00%> (-0.17%) ⬇️
...erver/storage/file/session/FileSessionManager.java 49.04% <0.00%> (-0.64%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 67.23% <0.00%> (+3.70%) ⬆️
...java/io/seata/server/storage/SessionConverter.java 89.09% <0.00%> (+9.09%) ⬆️
...va/io/seata/server/console/vo/GlobalSessionVO.java 55.88% <0.00%> (+33.82%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title bugfix:null exception when sql columns is empty in insert on duplica… bugfix: null exception when sql columns is empty in insert on duplicate Oct 28, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.6.0 milestone Oct 28, 2022
@funky-eyes funky-eyes added the module/rm-datasource rm-datasource module label Oct 28, 2022
@funky-eyes funky-eyes added the type: bug Category issues or prs related to bug. label Oct 29, 2022
slievrly pushed a commit to opentrx/seata that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/rm-datasource rm-datasource module multilingual type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

insert on duplicate语句不带列字段时出现空指针问题

4 participants