Skip to content

Conversation

@funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Sep 6, 2022

… matched

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

image

当数据库column为大写,而sql为小写时,读取parameter时匹配不上,造成了前镜像的sql为select * from table导致了全表扫描,后镜像也进行了一次全表扫描的bug

image

Ⅱ. Does this pull request fix one issue?

fixes #4909

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 1.6.0 milestone Sep 6, 2022
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Sep 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #4912 (f9f9550) into develop (8ec5ccd) will increase coverage by 0.01%.
The diff coverage is 45.45%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4912      +/-   ##
=============================================
+ Coverage      49.03%   49.04%   +0.01%     
- Complexity      4087     4088       +1     
=============================================
  Files            736      736              
  Lines          25784    25785       +1     
  Branches        3180     3180              
=============================================
+ Hits           12642    12646       +4     
+ Misses         11799    11798       -1     
+ Partials        1343     1341       -2     
Impacted Files Coverage Δ
...ava/io/seata/common/util/LowerCaseLinkHashMap.java 0.00% <0.00%> (ø)
...a/io/seata/rm/datasource/exec/ExecuteTemplate.java 5.55% <ø> (ø)
...seata/rm/datasource/undo/AbstractUndoExecutor.java 69.01% <0.00%> (ø)
...ec/mysql/MySQLInsertOnDuplicateUpdateExecutor.java 31.49% <55.55%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title bugfix: mysql insert or update column case is different and cannot be… bugfix: mysql insert or update column case is different and cannot be matched Sep 6, 2022
@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2022

This pull request introduces 1 alert when merging bdb6ee6 into 8ec5ccd - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2022

This pull request introduces 1 alert when merging f9f9550 into b5ddb71 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2022

This pull request introduces 1 alert when merging 6de7b0f into b5ddb71 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2022

This pull request introduces 1 alert when merging 87554b6 into b5ddb71 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

@slievrly slievrly changed the title bugfix: mysql insert or update column case is different and cannot be matched bugfix: mysql insert on update duplicate sensitive case not matched Sep 6, 2022
@slievrly slievrly merged commit de7d04f into apache:develop Sep 6, 2022
@luky116
Copy link

luky116 commented Nov 23, 2024

seata-go: apache/incubator-seata-go#700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/rm-datasource rm-datasource module multilingual type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

seata 1.5.2 jpa session请求 cpu飚高 疯狂gc

5 participants