Skip to content

Conversation

@pengten
Copy link
Contributor

@pengten pengten commented May 7, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

自动降级如果一开始为false,运行中也无法通过修改配置来动态开启

Ⅱ. Does this pull request fix one issue?

fixes #4491

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pengten pengten changed the title bugfix:auto degrade unable dynamic configure optimize: auto degrade unable dynamic configure May 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #4590 (796bd97) into develop (4dded88) will increase coverage by 0.00%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4590   +/-   ##
==========================================
  Coverage      49.29%   49.30%           
- Complexity      4116     4117    +1     
==========================================
  Files            737      737           
  Lines          25778    25790   +12     
  Branches        3187     3189    +2     
==========================================
+ Hits           12708    12715    +7     
- Misses         11721    11727    +6     
+ Partials        1349     1348    -1     
Impacted Files Coverage Δ
...ing/annotation/GlobalTransactionalInterceptor.java 33.14% <23.07%> (+1.21%) ⬆️
...erver/storage/file/session/FileSessionManager.java 54.14% <0.00%> (+0.63%) ⬆️

@funky-eyes funky-eyes added this to the 2.0.0 milestone May 17, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pr登记一下

@funky-eyes funky-eyes modified the milestones: 2.0.0, 1.6.0 Aug 11, 2022
@funky-eyes funky-eyes requested a review from slievrly August 20, 2022 15:11
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengten pengten force-pushed the bugfix/auto_degrade branch from 977dd99 to 796bd97 Compare August 21, 2022 02:56
@funky-eyes funky-eyes merged commit e3a4640 into apache:develop Aug 21, 2022
misselvexu pushed a commit to misselvexu/seata that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

降级开关启动时配置为false,后续动态修改为true,降级检测定时任务不会启动

5 participants