Skip to content

Conversation

ljmotta
Copy link
Contributor

@ljmotta ljmotta commented Sep 4, 2024

Many thanks for submitting your Pull Request ❤️!

Closes/Fixes/Resolves apache/incubator-kie-issues#1468

Description:

In a Windows machine, a nested resource will have a Windows path with backslash (\). The getResourceAsStream only supports Posix paths (/). This PR adds a toPosixPath method which transform Windows paths to Posix paths, and it keeps Posix paths unchanged.

Manually tested in Windows, WSL and macOS.

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

@ljmotta ljmotta self-assigned this Sep 4, 2024
@gitgabrio
Copy link
Contributor

@yesamer IIRC you already dealt with something similar in the past 🤔

@yesamer
Copy link
Contributor

yesamer commented Sep 5, 2024

@gitgabrio Yeah, but in another area I guess. And most likely this will be no the last case :V

@pefernan
Copy link
Contributor

pefernan commented Sep 9, 2024

guys give me a min to take a look before merging!

@baldimir
Copy link
Contributor

baldimir commented Sep 9, 2024

Just ping me when ready and I can merge @pefernan.

@pefernan
Copy link
Contributor

pefernan commented Sep 9, 2024

@baldimir +1

@baldimir baldimir merged commit c18910a into apache:main Sep 9, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting a project in development mode in Windows will fail if it has nested resources
6 participants