Skip to content

Conversation

Abhitocode
Copy link
Contributor

@Abhitocode Abhitocode commented Aug 1, 2024

In addition to previous changes associated,
Migrated tests within DataTest.Java

The test can be identified by referring to DataTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java

Closes apache/incubator-kie-issues#1131.

Note: will resolve conflicts once reviewed for any changes.

@elguardian elguardian marked this pull request as ready for review August 2, 2024 08:09
@elguardian
Copy link
Contributor

@Abhitocode plz fix the test.

Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@elguardian elguardian requested a review from martinweiler August 8, 2024 09:21
Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhitocode could you please create a follow up issue to improve the output tests and add an assert statement? Thanks!

@Abhitocode
Copy link
Contributor Author

sure, il update that.

@elguardian elguardian merged commit 143a3ab into apache:main Aug 9, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate process test migration from v7 legacy runtime to code generation
3 participants