IGNITE-22441 Add parameter object to Data Streamer #3971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PakhomovAlexander
approved these changes
Jun 21, 2024
| * @return This builder. | ||
| */ | ||
| public Builder units(List<DeploymentUnit> units) { | ||
| this.units = units; |
Contributor
There was a problem hiding this comment.
Shall we copy List?
Contributor
Author
There was a problem hiding this comment.
We don't copy in JobDescriptor. Also, units() property exposes a mutable List, so we would need to copy there as well for full protection. I don't think it's worth it, let's keep as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReceiverDescriptorparameter object to Data Streamer similar toJobDescriptorin Compute API.DataStreamerOptionsare not included inReceiverDescriptor, because semantically they are not related: options affect client-side streaming logic, and do not affect the receiver.https://issues.apache.org/jira/browse/IGNITE-22441