refactor(server): Utilize "usize" for numeric IDs #2234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to apache#2198, align ID types with the target pointer size "usize" to avoid churny casts and platform-specific inconsistencies. The following id are now being changed * stream_id * topic_id * partition_id * consumer_group_id For some parts revelant for "Identifier", simply cast the type to "u32/u64" directly for now. Additionally, in order to achieve ".into()" call that pass "usize" to get "IggyByteSize", implement "From<usize>" and "From<Option<usize>>" for "IggyByteSize". Signed-off-by: I Hsin Cheng <[email protected]>
vax-r
force-pushed
the
io_uring_tpc_unify_id
branch
from
b171351 to
4c73235
Compare
|
Hi, I've took a look at your PR, overall you've changed too much 😄 we wanted to change only the ids of following resources - stream/topics/partitions/consumer_groups on the server, not every single one occurrence of u32 values everywhere. You have to limit the scope of changes only to the server crate and only to the ids of mentioned resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
According to #2198 , align ID types with the target pointer size "usize" to avoid churny casts and platform-specific inconsistencies. The following id are now being changed
For some parts revelant for "Identifier", simply cast the type to "u32/u64" directly for now.
Additionally, in order to achieve ".into()" call that pass "usize" to get "IggyByteSize", implement "From" and "From<Option>" for "IggyByteSize".
Related Issue
#2198