Flink: Fix ResultSet resource leak in JdbcLockFactory.initializeLockTables(). #13821
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pvary @Guosmilesmile @mxm This is a relatively minor change, but I believe it is still necessary, as the current implementation does not release resources after using the |
stevenzwu
approved these changes
Aug 15, 2025
singhpk234
approved these changes
Aug 15, 2025
pvary
reviewed
Aug 15, 2025
| try (PreparedStatement ps = conn.prepareStatement(CREATE_LOCK_TABLE_SQL)) { | ||
| ps.execute(); | ||
| } | ||
| return true; |
There was a problem hiding this comment.
Thank you for helping review the code! I have already fixed this issue.
|
@slfan1989: good catch! Thanks for reporting and fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
JdbcLockFactory#initializeLockTables(), theResultSetreturned byDatabaseMetaData#getTables(...)is not closed explicitly. This can lead to resource leaks (open cursors/handles) on certain JDBC drivers and databases.Changes
ResultSetin a try-with-resources block to ensure it is always closed.