Skip to content

[MINOR] Add tests for autoUpgrade config during table creation #13677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2025

Conversation

linliu-code
Copy link
Contributor

@linliu-code linliu-code commented Aug 5, 2025

Change Logs

This PR adds tests on different scenarios with write table version during table creation.

Impact

Increased test coverage

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Aug 5, 2025
@linliu-code linliu-code force-pushed the upgrade_downgrade_autograde branch from ba99b8a to f7748a4 Compare August 5, 2025 15:20
@github-actions github-actions bot added size:M PR with lines of changes in (100, 300] and removed size:S PR with lines of changes in (10, 100] labels Aug 5, 2025
@linliu-code linliu-code force-pushed the upgrade_downgrade_autograde branch from f7748a4 to e110225 Compare August 5, 2025 15:28
@linliu-code linliu-code changed the title [MINOR] Standardize autoupgrade usage [MINOR] Add checks for autoUpgrade config during table creation Aug 5, 2025
@linliu-code linliu-code marked this pull request as ready for review August 5, 2025 15:29
@linliu-code linliu-code force-pushed the upgrade_downgrade_autograde branch from e110225 to 7295fa4 Compare August 7, 2025 13:44
@github-actions github-actions bot added size:S PR with lines of changes in (10, 100] and removed size:M PR with lines of changes in (100, 300] labels Aug 7, 2025
@linliu-code linliu-code force-pushed the upgrade_downgrade_autograde branch 2 times, most recently from cfcc9aa to 8acb632 Compare August 7, 2025 15:06
@github-actions github-actions bot added size:M PR with lines of changes in (100, 300] and removed size:S PR with lines of changes in (10, 100] labels Aug 7, 2025
@linliu-code linliu-code force-pushed the upgrade_downgrade_autograde branch from 8acb632 to b4e8043 Compare August 7, 2025 15:20
@linliu-code
Copy link
Contributor Author

@yihua , I have checked the Azure CI failure, which is caused by the check that does not allow table creation with version < 6 for existing tables. After your review, we can decide if I should fix them or remove the check.

@rahil-c
Copy link
Contributor

rahil-c commented Aug 10, 2025

@yihua @linliu-code the patch looks good to me, i think i will try to rebase this ontop of the recent behavior changes being introduced in PR #13687

After cherrypicking this PR, ontop of my pr #13687 and running tests, seems to pass fine.

I have opened a branch here #13702 just to confirm that all tests pass.

@linliu-code linliu-code force-pushed the upgrade_downgrade_autograde branch from b4e8043 to 19146d8 Compare August 11, 2025 20:17
@github-actions github-actions bot added size:S PR with lines of changes in (10, 100] and removed size:M PR with lines of changes in (100, 300] labels Aug 12, 2025
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihua yihua mentioned this pull request Aug 12, 2025
4 tasks
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua changed the title [MINOR] Add checks for autoUpgrade config during table creation [MINOR] Add tests for autoUpgrade config during table creation Aug 12, 2025
@yihua yihua merged commit 30e5275 into apache:master Aug 12, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants