-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[MINOR] Add tests for autoUpgrade config during table creation #13677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ba99b8a
to
f7748a4
Compare
f7748a4
to
e110225
Compare
e110225
to
7295fa4
Compare
cfcc9aa
to
8acb632
Compare
8acb632
to
b4e8043
Compare
@yihua , I have checked the Azure CI failure, which is caused by the check that does not allow table creation with version < 6 for existing tables. After your review, we can decide if I should fix them or remove the check. |
@yihua @linliu-code the patch looks good to me, i think i will try to rebase this ontop of the recent behavior changes being introduced in PR #13687 After cherrypicking this PR, ontop of my pr #13687 and running tests, seems to pass fine. I have opened a branch here #13702 just to confirm that all tests pass. |
b4e8043
to
19146d8
Compare
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
Outdated
Show resolved
Hide resolved
...-datasource/hudi-spark/src/test/java/org/apache/hudi/table/upgrade/TestUpgradeDowngrade.java
Outdated
Show resolved
Hide resolved
...-datasource/hudi-spark/src/test/java/org/apache/hudi/table/upgrade/TestUpgradeDowngrade.java
Outdated
Show resolved
Hide resolved
...-datasource/hudi-spark/src/test/java/org/apache/hudi/table/upgrade/TestUpgradeDowngrade.java
Outdated
Show resolved
Hide resolved
...-datasource/hudi-spark/src/test/java/org/apache/hudi/table/upgrade/TestUpgradeDowngrade.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Logs
This PR adds tests on different scenarios with write table version during table creation.
Impact
Increased test coverage
Risk level
none
Documentation Update
N/A
Contributor's checklist