Skip to content

fix(pie): fix some labels may not show #20074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ovilia merged 2 commits into from
Jul 18, 2024
Merged

fix(pie): fix some labels may not show #20074

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
769bfef
fix(pie): Missing pie chart label display. close #20070
zhangyu-ts Jun 25, 2024
403dce2
fix(pie): fix some labels may not show #20074
zhangyu-ts Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chart/pie/labelLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function adjustSingleSide(
const rA = r + item.len;
const rA2 = rA * rA;
// Use ellipse implicit function to calculate x
const dx = Math.sqrt((1 - Math.abs(dy * dy / rB2)) * rA2);
const dx = Math.sqrt(Math.abs((1 - Math.abs(dy * dy / rB2)) * rA2));
const newX = cx + (dx + item.len2) * dir;
const deltaX = newX - item.label.x;
const newTargetWidth = item.targetTextWidth - deltaX * dir;
Expand Down