dubbo3.3.3 NettyHttpHeaders.add NullPointerException

[robin977]

Pre-check

• I am sure that all the content I provide is in English.

Search before asking

• I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

the environment of the provider side：The version of Spring Boot is 3.4, and the version of Dubbo is 3.3.3.

Steps to reproduce this issue

on the provider side,a null pointer exception where the Triple protocol reuses the web port:

check the request header, there is no host field.

consumer side console：

What you expected to happen

Null value validation will be carried out here, and a default value needs to be added.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

• Yes I am willing to submit a pull request on my own!

Code of Conduct

• I agree to follow this project's Code of Conduct

[dheerajaraj]

Hi @robin977 I would like to fix this issue. Could you kindly assign it to me?

[dheerajaraj]

@robin977 I am new to Dubbo. I checked the docs for io.netty.handler.codec.Headers and it might be linked to this issue here.

As for the fix:
I checked where is PseudoHeaderName.AUTHORITY used. It is used in org.apache.dubbo.remoting.http12.message.DefaultHttpRequest.getHost0()#340. This method has 3 usages; all in org.apache.dubbo.remoting.http12.message.DefaultHttpRequest. I'm thinking of setting it to a default value of empty String "" and do the check for empty String in org.apache.dubbo.remoting.http12.message.DefaultHttpRequest

[robin977]

@robin977 I am new to Dubbo. I checked the docs for io.netty.handler.codec.Headers and it might be linked to this issue here.

As for the fix: I checked where is PseudoHeaderName.AUTHORITY used. It is used in org.apache.dubbo.remoting.http12.message.DefaultHttpRequest.getHost0()#340. This method has 3 usages; all in org.apache.dubbo.remoting.http12.message.DefaultHttpRequest. I'm thinking of setting it to a default value of empty String "" and do the check for empty String in org.apache.dubbo.remoting.http12.message.DefaultHttpRequest

Yes, that's right

[dheerajaraj]

@robin977 @oxsean Apologies in advance if this is not the correct channel to ask this question. I have made the fix locally however i cannot push my changes to my forked repository. I think I need to be a committer in order to do that.

I have submitted my ICLA to Apache and below is the reply screenshot.

At this point I'm very unsure as to how to proceed with the next steps: Should I wait for them to reply with an apache-id or will Dubbo send an invitation to Apache to assign me as a comitter? Kindly help please

[RainYuY]

@robin977 @oxsean Apologies in advance if this is not the correct channel to ask this question. I have made the fix locally however i cannot push my changes to my forked repository. I think I need to be a committer in order to do that.

I have submitted my ICLA to Apache and below is the reply screenshot.

At this point I'm very unsure as to how to proceed with the next steps: Should I wait for them to reply with an apache-id or will Dubbo send an invitation to Apache to assign me as a comitter? Kindly help please

@dheerajaraj Please follow this link: https://cn.dubbo.apache.org/en/contact/contributor/new-contributor-guide_dev/

[dheerajaraj]

@robin977 I have raised a PR for this fix and the checks are passing. It's good to be reviewed. @oxsean Is it ok i could be assigned this issue?

[oxsean]

@robin977 I have raised a PR for this fix and the checks are passing. It's good to be reviewed. @oxsean Is it ok i could be assigned this issue?

Done