Skip to content

Conversation

@zhouyao1994
Copy link
Contributor

The project dubbo-samples-tagrouter change the rule by yml
There are some scenarios where you need to write tags directly on dubbo , i think may be can add this example in it.

This strategy can be used to reduce time to return by avoid service call accross the IDC.
This can be achieved by putting the same tag on the same IDC service

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we design this demo in spring-boot style config.

@zhouyao1994
Copy link
Contributor Author

It would be better if we design this demo in spring-boot style config.

I agree,may be i can modify this,and pull request again.

@AlbumenJ
Copy link
Member

AlbumenJ commented Jan 5, 2023

image

Please fix failed test cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants