Feature/metadata service tri export clean #2983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
requested review from
FoghostCn,
Copilot and
marsevilspirit
and removed request for
Copilot and
marsevilspirit
wqyenjoy
force-pushed
the
feature/metadata-service-tri-export-clean
branch
from
1fda49d to
d120d00
Compare
AlexStocks
reviewed
Aug 24, 2025
AlexStocks
reviewed
Aug 24, 2025
metadata/metadata_service.go
Outdated
| // exportV2Services exports V2 metadata service on same port with different interface | ||
| // This ensures clients can discover V2 service using standard discovery mechanisms | ||
| func (e *serviceExporter) exportV2Services(port string) error { | ||
| return e.exportV2(port) |
FoghostCn
requested changes
Aug 25, 2025
| // do not set, because it will override MetadataService | ||
| //exporter.metadataService.SetMetadataServiceURL(ivkURL) | ||
|
|
||
| // Both V1 and V2 are now discoverable on same port with different interface names |
Contributor
There was a problem hiding this comment.
e.opts.protocol == 'tri or 'dubbo' not both
Comment on lines
+361
to
+363
| if metadataInfo == nil { | ||
| return nil, nil | ||
| } |
Contributor
There was a problem hiding this comment.
Silent failure is not good.
Contributor
Author
There was a problem hiding this comment.
i will return a clear failure
wqyenjoy
force-pushed
the
feature/metadata-service-tri-export-clean
branch
6 times, most recently
from
0192a8b to
9e2f73b
Compare
…lity - Add MetadataServiceV2 implementation with triple protocol support - Fix import formatting issues in metadata test files - Update import block ordering for imports-formatter compatibility - Add .cursorrules to .gitignore for local development rules - Improve metadata service error handling and compatibility
wqyenjoy
force-pushed
the
feature/metadata-service-tri-export-clean
branch
from
92d2e1f to
c9d7e7d
Compare
added 3 commits
August 30, 2025 12:37
- Update import indentation to match imports-formatter tool - Ensure CI formatting checks pass without modifications
- Remove unused serviceInvoker type and Invoke method - Remove unused convertV1 function - Remove unused emptyStrSlice variable in zookeeper report - Remove unused result package import Fixes golangci-lint errors for unused code
- Clean up empty lines in import sections - Ensure consistent import block formatting - Maintain imports-formatter compliance
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2983 +/- ##
===========================================
+ Coverage 39.36% 39.52% +0.16%
===========================================
Files 457 457
Lines 38863 38891 +28
===========================================
+ Hits 15299 15373 +74
+ Misses 22304 22254 -50
- Partials 1260 1264 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 3 commits
August 30, 2025 14:15
- Remove unnecessary single-line functions (shouldExportV2, exportV2Services) - Remove unused service discovery registration for metadata service - Fix silent failure issues by returning proper error messages - Update test cases to handle new error return behavior - Remove duplicate import declaration Addresses reviewer feedback: - AlexStocks: Simplified single-line functions - FoghostCn: Removed unnecessary service discovery, fixed silent failures
- Reorganize imports into standard three-block format: * Block 1: Standard library imports * Block 2: Third-party library imports * Block 3: Internal project imports - Ensure consistent import ordering and formatting - Maintain compliance with project's import style guide
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| requestData = make(map[string]any) | ||
| } | ||
|
|
||
| log.Printf("请求数据: %+v", requestData) |
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks Low
| return | ||
| } | ||
|
|
||
| log.Printf("转换参数: types=%v, args=%+v", methodSchema.ParameterTypes, tripleArgs) |
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks Low
|
|
||
| // 写入错误响应 | ||
| func (gw *TripleGateway) writeErrorResponse(w http.ResponseWriter, statusCode int, message string) { | ||
| log.Printf("错误响应: %d - %s", statusCode, message) |
Check notice
Code scanning / SonarCloud
Logging should not be vulnerable to injection attacks Low
wqyenjoy
force-pushed
the
feature/metadata-service-tri-export-clean
branch
from
8c41fdb to
5aba962
Compare
|
Contributor
|
pls fix ci fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: format imports and finalize MetadataServiceV2 implementation