Skip to content

Conversation

@xuzhijvn
Copy link
Contributor

No description provided.

@xuzhijvn xuzhijvn force-pushed the feature/add-apollo-sample branch from 2efb919 to a98ad1e Compare July 26, 2025 03:50
@Alanxtl
Copy link
Contributor

Alanxtl commented Jul 26, 2025

please fmt import blocks using import-formatter

@Alanxtl
Copy link
Contributor

Alanxtl commented Jul 26, 2025

Add the introduction of this sample to the README.md and README_CN.md in the root directory

@xuzhijvn
Copy link
Contributor Author

Add the introduction of this sample to the README.md and README_CN.md in the root directory

Thanks for the reply. I don’t think it’s necessary — since we already have e.g., there’s no need to list all implementations.

@xuzhijvn xuzhijvn force-pushed the feature/add-apollo-sample branch from a98ad1e to 4dce58b Compare August 1, 2025 09:11
@AlexStocks
Copy link
Contributor

Add the introduction of this sample to the README.md and README_CN.md in the root directory

Thanks for the reply. I don’t think it’s necessary — since we already have e.g., there’s no need to list all implementations.

We really hope you add this sample on the program list in readme.

@xuzhijvn xuzhijvn force-pushed the feature/add-apollo-sample branch 2 times, most recently from f31fe9f to fb4b982 Compare August 8, 2025 13:53
@1kasa
Copy link
Contributor

1kasa commented Aug 8, 2025

The CI error here should be a problem with the formatted code. Use the imports-formatter tool in the https://github.com/dubbogo/tools repository to format it.

@AlexStocks AlexStocks requested a review from Copilot August 8, 2025 15:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Apollo configuration center support to Dubbo-Go samples. It introduces a new sample demonstrating how to use Apollo as a configuration center for dynamic configuration management in Dubbo-Go applications.

  • Adds Apollo config center example with client and server implementations
  • Updates go.mod to include Apollo dependencies and upgrade Dubbo-Go version
  • Updates documentation to reflect Apollo support

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
go.mod Updates Dubbo-Go version and adds Apollo-related dependencies
config_center/apollo/proto/* Adds protobuf definitions and generated code for greet service
config_center/apollo/go-server/cmd/main.go Implements server using Apollo config center
config_center/apollo/go-client/cmd/main.go Implements client using Apollo config center
config_center/apollo/README*.md Documentation for Apollo sample usage
README*.md Updates main documentation to mention Apollo support

@xuzhijvn xuzhijvn force-pushed the feature/add-apollo-sample branch from fb4b982 to 2d76814 Compare October 29, 2025 03:01
@xuzhijvn xuzhijvn force-pushed the feature/add-apollo-sample branch from 2d76814 to c3d6f7a Compare October 29, 2025 06:04
@xuzhijvn xuzhijvn requested a review from AlexStocks October 29, 2025 06:09
),
)
if err != nil {
panic(err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上下文中用 panic 的地方,改成 log.Fatal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panic不是好的编程习惯

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@xuzhijvn xuzhijvn force-pushed the feature/add-apollo-sample branch from ead24e0 to f70f7e4 Compare October 31, 2025 09:49
@AlexStocks AlexStocks merged commit 02b84f6 into apache:main Oct 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants