- 
                Notifications
    You must be signed in to change notification settings 
- Fork 216
Feature/add apollo sample #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2efb919    to
    a98ad1e      
    Compare
  
    | please fmt import blocks using import-formatter | 
| Add the introduction of this sample to the README.md and README_CN.md in the root directory | 
| 
 Thanks for the reply. I don’t think it’s necessary — since we already have  | 
a98ad1e    to
    4dce58b      
    Compare
  
    | 
 We really hope you add this sample on the program list in readme. | 
f31fe9f    to
    fb4b982      
    Compare
  
    | The CI error here should be a problem with the formatted code. Use the  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Apollo configuration center support to Dubbo-Go samples. It introduces a new sample demonstrating how to use Apollo as a configuration center for dynamic configuration management in Dubbo-Go applications.
- Adds Apollo config center example with client and server implementations
- Updates go.mod to include Apollo dependencies and upgrade Dubbo-Go version
- Updates documentation to reflect Apollo support
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description | 
|---|---|
| go.mod | Updates Dubbo-Go version and adds Apollo-related dependencies | 
| config_center/apollo/proto/* | Adds protobuf definitions and generated code for greet service | 
| config_center/apollo/go-server/cmd/main.go | Implements server using Apollo config center | 
| config_center/apollo/go-client/cmd/main.go | Implements client using Apollo config center | 
| config_center/apollo/README*.md | Documentation for Apollo sample usage | 
| README*.md | Updates main documentation to mention Apollo support | 
fb4b982    to
    2d76814      
    Compare
  
    2d76814    to
    c3d6f7a      
    Compare
  
    # Conflicts: # go.mod # go.sum
        
          
                config_center/apollo/README.md
              
                Outdated
          
        
      | ), | ||
| ) | ||
| if err != nil { | ||
| panic(err) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上下文中用 panic 的地方,改成 log.Fatal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
panic不是好的编程习惯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
ead24e0    to
    f70f7e4      
    Compare
  
    
No description provided.