Decouple AllTrue, AllUnknown BitmapColumnIndex from ColumnIndexSelector. #18432
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no real need for these objects to require a ColumnIndexSelector for construction. All they need is the bitmap factory and row count. This change makes it easier to use these classes from places where a ColumnIndexSelector is not available, such as implementations of semantic indexes. This also brings these classes more in line with AllFalseBitmapColumnIndex, which just takes a bitmap factory.
clintropolis
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no real need for these objects to require a ColumnIndexSelector for construction. All they need is the bitmap factory and row count. This change makes it easier to use these classes from places where a ColumnIndexSelector is not available, such as implementations of semantic indexes.
This also brings these classes more in line with AllFalseBitmapColumnIndex, which just takes a bitmap factory.