Minor: Fix incorrect indices for hashing struct #8775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
commented
Jan 6, 2024
| let num_columns = array.num_columns(); | ||
| let row_len = array.len(); | ||
|
|
||
| // Skip null columns |
Contributor
Author
There was a problem hiding this comment.
I forgot to correct the comment last time. Indices are all about row, not columns
jayzhan211
commented
Jan 6, 2024
| let valid_row_indices: Vec<usize> = if let Some(nulls) = nulls { | ||
| nulls.valid_indices().collect() | ||
| } else { | ||
| (0..num_columns).collect() |
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
commented
Jan 6, 2024
| 10 | ||
|
|
||
| query RRR | ||
| query RRR rowsort |
Contributor
Author
There was a problem hiding this comment.
rowsort is added because I got and groupby is not order sensitive
700 1000 850
100 600 350
Contributor
There was a problem hiding this comment.
Yeah -- also added the same fix in #8769 and I agree this looks good
alamb
approved these changes
Jan 6, 2024
| 10 | ||
|
|
||
| query RRR | ||
| query RRR rowsort |
Contributor
There was a problem hiding this comment.
Yeah -- also added the same fix in #8769 and I agree this looks good
This was referenced Jan 6, 2024
thinkharderdev
pushed a commit
to coralogix/arrow-datafusion
that referenced
this pull request
Feb 26, 2024
* fix bug Signed-off-by: jayzhan211 <[email protected]> * fmt Signed-off-by: jayzhan211 <[email protected]> * add rowsort Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Bug in #8552
closes #8769
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Failed test is added
Are there any user-facing changes?