Fix CCM not cleaning up all nodes if one fails to start #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcapwell
approved these changes
May 22, 2025
| pass | ||
|
|
||
| def __unix_kill(self, sig): | ||
| self.__unix_kill_process_matching(".*{}.*{}.*".format(self.__log_dir(), "org.apache.cassandra.service.CassandraDaemon"), sig) |
michaelsembwever
approved these changes
May 23, 2025
|
@aweisberg , looks like new failures here too: http://35.228.140.106:8080/job/cassandra/241/#showFailuresLink |
aweisberg
force-pushed
the
20673
branch
2 times, most recently
from
e5cc628 to
1fa5aca
Compare
|
looking good: http://35.228.140.106:8080/job/cassandra/242/ |
michaelsembwever
approved these changes
May 24, 2025
Patch by Ariel Weisberg; Reviewed by Mick Semb Wever for CASSANDRA-20673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by Ariel Weisberg; Reviewed by Mick Semb Wever for CASSANDRA-20673