[CALCITE-7261] DiffRepository generation xml does not respect alphabetical order
#4612
+96
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
commented
Nov 2, 2025
| final List<String> names = Pair.left(map); | ||
| for (String s : names) { | ||
| if (s.compareToIgnoreCase(testCaseName) <= 0) { | ||
| if (s.compareTo(testCaseName) <= 0) { |
There was a problem hiding this comment.
as here lexicographical order with respect of case is used
calcite/testkit/src/main/java/org/apache/calcite/test/DiffRepository.java
Lines 643 to 645 in 67e5bfc
snuyanzin
commented
Nov 2, 2025
| ~ See the License for the specific language governing permissions and | ||
| ~ limitations under the License. | ||
| --> | ||
| <Root></Root> |
There was a problem hiding this comment.
dummy xml in order to generate and test actual
|
mihaibudiu
approved these changes
Nov 2, 2025
caicancai
approved these changes
Nov 4, 2025
| /** | ||
| * Tests checking generated actual XML version. | ||
| */ | ||
| public class DiffRepositoryGeneratedFileTest { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that from one side there is already existing validation of test cases present in xml, from another side if an xml is generated from scratch (
_actual.xml) then the generated version might contain test cases in wrong order