Skip to content

Conversation

@liangyepianzhou
Copy link
Contributor

@liangyepianzhou liangyepianzhou commented Oct 15, 2025

Motivation

Fix flaky test: https://github.com/apache/bookkeeper/actions/runs/18525197327/job/52795009929?pr=4652

Changes

To maintain consistency and reduce future modifications, all assertion timeouts in testEmptyLedgerLosesQuorumEventually that use the format assertTrue(xxx, latch.await(xx)) have been unified to 20 seconds.

These assertion timeouts in this test have been changed several times, with each change only increasing the timeout of one assertion. To avoid repeated modifications in the future, these timeouts in this test have been aligned to the longest timeout value that was previously set.

assertTrue("Should be marked as replicated", latch.await(20, TimeUnit.SECONDS));

Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good jobs

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a flaky test by standardizing timeout values in the testEmptyLedgerLosesQuorumEventually test method. The changes align all assertion timeouts to 20 seconds to prevent test failures due to timing inconsistencies.

  • Increased timeout values from 5 and 15 seconds to a consistent 20 seconds
  • Standardized timeout duration across multiple assertions within the same test
  • Addressed flaky test behavior identified in CI builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@liangyepianzhou
Copy link
Contributor Author

/bkbot rerun

@liangyepianzhou
Copy link
Contributor Author

reopen due to #4665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants