WriteLacResponse should be processed in the same thread as other requ… #3452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests for same ledgerId In PCBC code, the WriteLacCompletion object uses LAC as the key for selecting the thread in which the response will be processed. However, according to bookkeeper code guarantees, the thread should be decided based on hash of ledgerId.
Member
|
the old workflow has error,the bug is fixed in #3451
|
hezhangjian
approved these changes
Aug 20, 2022
Contributor
eolivelli
pushed a commit
that referenced
this pull request
Aug 21, 2022
#3452) * WriteLacResponse should be processed in the same thread as other requests for same ledgerId In PCBC code, the WriteLacCompletion object uses LAC as the key for selecting the thread in which the response will be processed. However, according to bookkeeper code guarantees, the thread should be decided based on hash of ledgerId. * Empty-Commit
eolivelli
pushed a commit
that referenced
this pull request
Aug 21, 2022
#3452) * WriteLacResponse should be processed in the same thread as other requests for same ledgerId In PCBC code, the WriteLacCompletion object uses LAC as the key for selecting the thread in which the response will be processed. However, according to bookkeeper code guarantees, the thread should be decided based on hash of ledgerId. * Empty-Commit
eolivelli
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Aug 21, 2022
apache#3452) * WriteLacResponse should be processed in the same thread as other requests for same ledgerId In PCBC code, the WriteLacCompletion object uses LAC as the key for selecting the thread in which the response will be processed. However, according to bookkeeper code guarantees, the thread should be decided based on hash of ledgerId. * Empty-Commit
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
apache#3452) * WriteLacResponse should be processed in the same thread as other requests for same ledgerId In PCBC code, the WriteLacCompletion object uses LAC as the key for selecting the thread in which the response will be processed. However, according to bookkeeper code guarantees, the thread should be decided based on hash of ledgerId. * Empty-Commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ests for same ledgerId
In PCBC code, the WriteLacCompletion object uses LAC as the key for selecting the thread in which the response
will be processed. However, according to bookkeeper code guarantees, the thread should be decided based on hash of ledgerId.