Skip to content

ARROW-1414: [GLib] Cast after status check #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kou wants to merge 1 commit into from
Closed

ARROW-1414: [GLib] Cast after status check #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion c_glib/arrow-glib/reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ garrow_record_batch_stream_reader_new(GArrowInputStream *stream,
auto arrow_input_stream = garrow_input_stream_get_raw(stream);
std::shared_ptr<BaseType> arrow_reader;
auto status = ReaderType::Open(arrow_input_stream, &arrow_reader);
auto subtype = std::dynamic_pointer_cast<ReaderType>(arrow_reader);
if (garrow_error_check(error, status, "[record-batch-stream-reader][open]")) {
auto subtype = std::dynamic_pointer_cast<ReaderType>(arrow_reader);
return garrow_record_batch_stream_reader_new_raw(&subtype);
} else {
return NULL;
Expand Down
4 changes: 2 additions & 2 deletions c_glib/arrow-glib/writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,8 @@ garrow_record_batch_stream_writer_new(GArrowOutputStream *sink,
auto status = WriterType::Open(arrow_sink,
garrow_schema_get_raw(schema),
&arrow_writer);
auto subtype = std::dynamic_pointer_cast<WriterType>(arrow_writer);
if (garrow_error_check(error, status, "[record-batch-stream-writer][open]")) {
auto subtype = std::dynamic_pointer_cast<WriterType>(arrow_writer);
return garrow_record_batch_stream_writer_new_raw(&subtype);
} else {
return NULL;
Expand Down Expand Up @@ -270,8 +270,8 @@ garrow_record_batch_file_writer_new(GArrowOutputStream *sink,
auto status = WriterType::Open(arrow_sink.get(),
garrow_schema_get_raw(schema),
&arrow_writer);
auto subtype = std::dynamic_pointer_cast<WriterType>(arrow_writer);
if (garrow_error_check(error, status, "[record-batch-file-writer][open]")) {
auto subtype = std::dynamic_pointer_cast<WriterType>(arrow_writer);
return garrow_record_batch_file_writer_new_raw(&subtype);
} else {
return NULL;
Expand Down