Skip to content

ARROW-1410: Remove MAP_POPULATE flag when mmapping files in Plasma store. #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robertnishihara wants to merge 2 commits into from
Closed

ARROW-1410: Remove MAP_POPULATE flag when mmapping files in Plasma store. #992

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b75bd9
Remove MAP_POPULATE flag when mmapping files in Plasma store.
robertnishihara Aug 25, 2017
8ed9612
Remove unnecessary ifdef.
robertnishihara Aug 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions cpp/src/plasma/malloc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,14 +134,10 @@ void* fake_mmap(size_t size) {

int fd = create_buffer(size);
ARROW_CHECK(fd >= 0) << "Failed to create buffer during mmap";
#ifdef __linux__
// MAP_POPULATE will pre-populate the page tables for this memory region
// which avoids work when accessing the pages later. Only supported on Linux.
void* pointer =
mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED | MAP_POPULATE, fd, 0);
#else
// MAP_POPULATE can be used to pre-populate the page tables for this memory region
// which avoids work when accessing the pages later. However it causes long pauses
// when mmapping the files. Only supported on Linux.
void* pointer = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
#endif
if (pointer == MAP_FAILED) {
ARROW_LOG(ERROR) << "mmap failed with error: " << std::strerror(errno);
if (errno == ENOMEM && plasma::plasma_config->hugepages_enabled) {
Expand Down