Skip to content

ARROW-1386: [C++] Unpin CMake version in MSVC toolchain builds #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesm wants to merge 1 commit into from
Closed

ARROW-1386: [C++] Unpin CMake version in MSVC toolchain builds #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ci/msvc-build.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,11 @@ conda create -n arrow -q -y python=%PYTHON% ^
six pytest setuptools numpy pandas cython ^
thrift-cpp

@rem ARROW-1294 CMake 3.9.0 in conda-forge breaks the build
set ARROW_CMAKE_VERSION=3.8.0

if "%JOB%" == "Toolchain" (

conda install -n arrow -q -y -c conda-forge ^
flatbuffers rapidjson ^
cmake=%ARROW_CMAKE_VERSION% ^
cmake ^
git ^
boost-cpp ^
snappy zlib brotli gflags lz4-c zstd
Expand Down
4 changes: 1 addition & 3 deletions dev/release/verify-release-candidate.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,12 @@
@rem libray build rem dependencies if you want to build them from source as well
@rem

@rem ARROW-1294 CMake 3.9.0 in conda-forge breaks the build
@rem set ARROW_CMAKE_VERSION=3.8.0
@rem set PYTHON=3.6
@rem conda create -n arrow-verify-release -f -q -y python=%PYTHON%
@rem conda install -y ^
@rem six pytest setuptools numpy pandas cython ^
@rem thrift-cpp flatbuffers rapidjson ^
@rem cmake=%ARROW_CMAKE_VERSION% ^
@rem cmake ^
@rem git ^
@rem boost-cpp ^
@rem snappy zlib brotli gflags lz4-c zstd || exit /B
Expand Down