ARROW-11132: [CI] Use pip to install crossbow's dependencies for the comment bot #9103
Conversation
kszucs
force-pushed
the
comment-bot-pip
branch
from
d415404 to
71abf11
Compare
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
kszucs
changed the title
| uses: actions/checkout@v2 | ||
| with: | ||
| path: arrow | ||
| # because libgit2 is a dependency of crossbow so prefer conda |
There was a problem hiding this comment.
pygit2 ships wheels now with libgit2 bundled
kszucs
left a comment
kszucs
left a comment
There was a problem hiding this comment.
We can try out the comment bot once the PR gets merged to master.
+1, merging on green
| extras = { | ||
| 'benchmark': ['pandas'], | ||
| 'bot': ['ruamel.yaml', 'pygithub'], | ||
| # bot extra includes crossbow's dependencies |
There was a problem hiding this comment.
Might it make sense to separate crossbow's dependencies and specify the install as arrow/dev/archery[bot,crossbow]?
That way you could install the dependencies with one of the other extras. This is partially because I'm not sure if I should use arrow/dev/archery[bot] for what I'm copying in #8915 from 7f11abe#diff-90e4e8bfd9b23a7b4bf4cfa1cb4bd0d80a87e21ac7fbd3a39c30f19709d4c705R50-R61
There was a problem hiding this comment.
This is repeated a lot, and I'm probably going to just open a different PR for cleaning up the repeated crossbow dependencies that way #8915 can hopefully be merged in sooner rather than later. It looks like it's built correctly (it was working before Travis disappeared).
2 participants
No description provided.