ARROW-1070: [C++] Use physical types for Feather date/time types #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I0f8a755b40b52146b4ac32c1bfb82f192a5c88b1
xxlaykxx
added a commit
to xxlaykxx/arrow
that referenced
this pull request
Oct 2, 2025
## What's Changed ExtensionReader was added to support reading extension types from a complex vector. It contains **read(ExtensionHolder)** method for reading to the holder. And **readObject** - for reading the value explicitly. Closes apache#725. (cherry picked from commit e6da71e871a3678a737a88dbe79491b4111496b4)
xxlaykxx
added a commit
to dremio/arrow
that referenced
this pull request
Oct 3, 2025
* apacheGH-725: Added ExtensionReader (apache#726) ## What's Changed ExtensionReader was added to support reading extension types from a complex vector. It contains **read(ExtensionHolder)** method for reading to the holder. And **readObject** - for reading the value explicitly. Closes apache#725. (cherry picked from commit e6da71e871a3678a737a88dbe79491b4111496b4) * MINOR: Fix format (apache#809) ## What's Changed Apply pre-commit since I forgot. (cherry picked from commit e4f64269db0a08299fa25be491570be5ba71d623) * apacheGH-836: Added support of ExtensionType for ComplexCopier (apache#837) ## What's Changed Updated ComplexCopier to support ExtensionType - it contains two **copy** methods ``` public static void copy(FieldReader input, FieldWriter output) //for not breaking existing logic public static void copy(FieldReader input, FieldWriter output, ExtensionTypeWriterFactory extensionTypeWriterFactory) ``` Also updated ComplexCopier tests. Closes apache#836. (cherry picked from commit 34060eb491a870f5ede5d30e007060b8310dc64f) * fix after merge * fix after macos build * fix after macos build * fix macos build * fix macos build * fix macos build * fix after merge --------- Co-authored-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from Feather 0.3.1. Closes wesm/feather#304