Skip to content

ARROW-813: [Python] setup.py sdist must also bundle dependent cmake m… #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xhochy wants to merge 3 commits into from
Closed

ARROW-813: [Python] setup.py sdist must also bundle dependent cmake m… #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70ca0d8
ARROW-813: [Python] setup.py sdist must also bundle dependent cmake m…
xhochy May 8, 2017
5b3b4a4
Symlink fixes
xhochy May 9, 2017
47459ba
Call git later
xhochy May 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,6 @@ init:
- set PATH=%MINICONDA%;%MINICONDA%/Scripts;%MINICONDA%/Library/bin;%PATH%

build_script:
- call ci\msvc-build.bat
- git config core.symlinks true
- git reset --hard
- call ci\msvc-build.bat
4 changes: 4 additions & 0 deletions dev/release/run-rat.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@ $RAT $1 \
-e status.h \
-e asan_symbolize.py \
-e cpplint.py \
-e BuildUtils.cmake \
-e FindPythonLibsNew.cmake \
-e FindNumPy.cmake \
-e SetupCxxFlags.cmake \
-e CompilerInfo.cmake \
-e pax_global_header \
-e MANIFEST.in \
-e __init__.pxd \
Expand Down
5 changes: 0 additions & 5 deletions python/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ project(pyarrow)

set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake_modules")

# Use common cmake modules from Arrow C++ if available
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/../cpp/cmake_modules")

include(CMakeParseArguments)

# Compatibility with CMake 3.1
Expand All @@ -34,8 +31,6 @@ if(POLICY CMP0054)
cmake_policy(SET CMP0054 NEW)
endif()

set(BUILD_SUPPORT_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../cpp/build-support")

# Allow "make install" to not depend on all targets.
#
# Must be declared in the top-level CMakeLists.txt.
Expand Down
1 change: 1 addition & 0 deletions python/cmake_modules/BuildUtils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../cpp/cmake_modules/BuildUtils.cmake
1 change: 1 addition & 0 deletions python/cmake_modules/CompilerInfo.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../cpp/cmake_modules/CompilerInfo.cmake
1 change: 1 addition & 0 deletions python/cmake_modules/FindNumPy.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../cpp/cmake_modules/FindNumPy.cmake
1 change: 1 addition & 0 deletions python/cmake_modules/FindPythonLibsNew.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../cpp/cmake_modules/FindPythonLibsNew.cmake
1 change: 1 addition & 0 deletions python/cmake_modules/SetupCxxFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../cpp/cmake_modules/SetupCxxFlags.cmake