Skip to content

ARROW-7546: [Java] Use new implementation to concat vectors values in batch #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tianchen92 wants to merge 1 commit into from
Closed

ARROW-7546: [Java] Use new implementation to concat vectors values in batch #6431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
import org.apache.arrow.vector.types.pojo.Field;
import org.apache.arrow.vector.types.pojo.Schema;
import org.apache.arrow.vector.util.DictionaryUtility;
import org.apache.arrow.vector.util.TransferPair;
import org.apache.arrow.vector.util.VectorBatchAppender;

/**
* Abstract class to read Schema and ArrowRecordBatches.
Expand Down Expand Up @@ -224,7 +224,8 @@ protected void loadDictionary(ArrowDictionaryBatch dictionaryBatch) {
if (dictionaryBatch.isDelta()) {
FieldVector deltaVector = vector.getField().createVector(allocator);
load(dictionaryBatch, deltaVector);
concatDeltaDictionary(vector, deltaVector);
VectorBatchAppender.batchAppend(vector, deltaVector);
deltaVector.close();
return;
}

Expand All @@ -242,18 +243,4 @@ private void load(ArrowDictionaryBatch dictionaryBatch, FieldVector vector) {
dictionaryBatch.close();
}
}

/**
* Concat dictionary vector and delta dictionary vector.
*/
private void concatDeltaDictionary(FieldVector vector, FieldVector deltaVector) {
final int valueCount = vector.getValueCount();
final int deltaValueCount = deltaVector.getValueCount();
final TransferPair transferPair = deltaVector.makeTransferPair(vector);
for (int i = 0; i < deltaValueCount; i++) {
transferPair.copyValueSafe(i, valueCount + i);
}
deltaVector.close();
vector.setValueCount(valueCount + deltaValueCount);
}
}