-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-7761: [C++][Python] Support S3 URIs #6403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d805f8a to
02229c6
Compare
2294951 to
ddcb28f
Compare
|
Works great :D |
|
One thing that I noted in my local integration, I had to explicit the global init of S3. I think it might be worth providing a default or implicitly calling the init step in |
Allow instantiating an S3 filesystem instance from a `s3://user:pass@bucket/path?params...` URI.
89611f8 to
3c73b76
Compare
|
@fsaintjacques Could you try again now? |
|
I pushed a change to the dataset example, it seems to be lost did you push force before pulling? It was a small change, I can make it again. |
|
Oh, sorry. Yes, I force-pushed after rebasing :-/ |
|
It should pass the CI, I'll merge after. The diff of the dataset example shows how well designed the APIs is. |
Allow instantiating an S3 filesystem instance from a
s3://user:pass@bucket/path?params...URI.