Skip to content

ARROW-7762: [Python] Do not ignore exception for invalid version in ParquetWriter #6352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorisvandenbossche wants to merge 1 commit into from
Closed

ARROW-7762: [Python] Do not ignore exception for invalid version in ParquetWriter #6352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/pyarrow/_parquet.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1304,14 +1304,15 @@ cdef class ParquetWriter:
else:
props.disallow_truncated_timestamps()

cdef void _set_version(self, WriterProperties.Builder* props):
cdef int _set_version(self, WriterProperties.Builder* props) except -1:
if self.version is not None:
if self.version == "1.0":
props.version(ParquetVersion_V1)
elif self.version == "2.0":
props.version(ParquetVersion_V2)
else:
raise ArrowException("Unsupported Parquet format version")
raise ValueError("Unsupported Parquet format version: {0}"
.format(self.version))

cdef void _set_compression_props(self, WriterProperties.Builder* props):
if isinstance(self.compression, basestring):
Expand Down
6 changes: 6 additions & 0 deletions python/pyarrow/tests/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,12 @@ def test_pandas_parquet_2_0_roundtrip(tempdir, chunk_size):
tm.assert_frame_equal(df, df_read)


def test_parquet_invalid_version(tempdir):
table = pa.table({'a': [1, 2, 3]})
with pytest.raises(ValueError, match="Unsupported Parquet format version"):
_write_table(table, tempdir / 'test_version.parquet', version="2.2")


def test_set_data_page_size():
arr = pa.array([1, 2, 3] * 100000)
t = pa.Table.from_arrays([arr], names=['f0'])
Expand Down