ARROW-6757: [Release] Use same CMake generator for C++ and Python when verifying RC, remove Python 3.5 from wheel verification #6350
Conversation
| @rem This is the path for Visual Studio Community 2017 | ||
| call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\Tools\VsDevCmd.bat" -arch=amd64 | ||
|
|
||
| cmake -G "Ninja" ^ |
There was a problem hiding this comment.
If anyone knows how to control the MSVC version used by Ninja let me know
There was a problem hiding this comment.
This is usually done by calling the vcvarsall.bat script for the particular MSVC install (or apparently VsDevCmd in more recent versions).
There was a problem hiding this comment.
We had this conversation in the past, I think. The MSVC "environment setup" scripts provided by VS are more crude than what can be obtained using the -G flag.
Using an explicit generator it's possible to choose the exact toolchain you want, but you must use msbuild, not Ninja. It would be interesting to know if there's a way to both use Ninja and select the target toolchain. The answer may be no but anyway it would be nice to know
There was a problem hiding this comment.
I didn't try it but we may be able to use -DMSVC_TOOLSET_VERSION=142 for Visual C++ 2019 or something: https://cmake.org/cmake/help/latest/variable/MSVC_TOOLSET_VERSION.html#variable:MSVC_TOOLSET_VERSION
|
Could you open a JIRA to remove the hardcoded CMake generator in |
|
+1. I'll open a JIRA (though I'm not sure how we will get setup.py to choose the right generator if one is not passed) |
…n verifying RC, remove Python 3.5 from wheel verification This resolves the issues I was having as described in ARROW-6757. This does not fix the Python 3.8 wheel, though Closes #6350 from wesm/windows-rc-verify-fixes and squashes the following commits: a9d4c66 <Wes McKinney> Fixes for Windows release verification scripts Authored-by: Wes McKinney <[email protected]> Signed-off-by: Wes McKinney <[email protected]>
3 participants
This resolves the issues I was having as described in ARROW-6757. This does not fix the Python 3.8 wheel, though