Skip to content

ARROW-7751: [Release] macOS wheel verification also needs arrow-testing #6345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nealrichardson wants to merge 3 commits into from
Closed

ARROW-7751: [Release] macOS wheel verification also needs arrow-testing #6345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e165d54
Make sure macOS wheel verification has test data
nealrichardson Feb 3, 2020
df9ef25
Move addition and fix lint
nealrichardson Feb 3, 2020
a29e88a
factor out testing repository cloning
kszucs Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/src/arrow/flight/test_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,8 @@ Status TestClientBasicAuthHandler::GetToken(std::string* token) {
Status GetTestResourceRoot(std::string* out) {
const char* c_root = std::getenv("ARROW_TEST_DATA");
if (!c_root) {
return Status::IOError("Test resources not found, set ARROW_TEST_DATA");
return Status::IOError(
"Test resources not found, set ARROW_TEST_DATA to <repo root>/testing/data");
}
*out = std::string(c_root);
return Status::OK();
Expand Down
24 changes: 15 additions & 9 deletions dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,18 @@ test_integration() {
$INTEGRATION_TEST_ARGS
}

clone_testing_repositories() {
# Clone testing repositories if not cloned already
if [ ! -d "arrow-testing" ]; then
git clone https://github.com/apache/arrow-testing.git
fi
if [ ! -d "parquet-testing" ]; then
git clone https://github.com/apache/parquet-testing.git
fi
export ARROW_TEST_DATA=$PWD/arrow-testing/data
export PARQUET_TEST_DATA=$PWD/parquet-testing/data
}

test_source_distribution() {
export ARROW_HOME=$TMPDIR/install
export PARQUET_HOME=$TMPDIR/install
Expand All @@ -534,15 +546,7 @@ test_source_distribution() {
NPROC=$(nproc)
fi

# Clone testing repositories if not cloned already
if [ ! -d "arrow-testing" ]; then
git clone https://github.com/apache/arrow-testing.git
fi
if [ ! -d "parquet-testing" ]; then
git clone https://github.com/apache/parquet-testing.git
fi
export ARROW_TEST_DATA=$PWD/arrow-testing/data
export PARQUET_TEST_DATA=$PWD/parquet-testing/data
clone_testing_repositories

if [ ${TEST_JAVA} -gt 0 ]; then
test_package_java
Expand Down Expand Up @@ -668,6 +672,8 @@ test_macos_wheels() {
}

test_wheels() {
clone_testing_repositories

local download_dir=binaries
mkdir -p ${download_dir}

Expand Down
2 changes: 1 addition & 1 deletion python/pyarrow/tests/test_flight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def resource_root():
"""Get the path to the test resources directory."""
if not os.environ.get("ARROW_TEST_DATA"):
raise RuntimeError("Test resources not found; set "
"ARROW_TEST_DATA to <repo root>/testing")
"ARROW_TEST_DATA to <repo root>/testing/data")
return pathlib.Path(os.environ["ARROW_TEST_DATA"]) / "flight"


Expand Down