ARROW-7750: [Release] Make the source release verification script restartable #6344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
changed the title
Member
|
I attempted to use this when verifying the release candidate but did not realize I had to set an env var to have a persistent directory. It otherwise succeeded, but then the Not critical since the verification already succeeded I guess. |
nealrichardson
added a commit
to nealrichardson/arrow
that referenced
this pull request
Feb 3, 2020
kszucs
added a commit
that referenced
this pull request
Feb 4, 2020
This addition follows the pattern of `test_source_distribution` (as it is in #6344). There are also two error message patches to make them consistent with everywhere else that references this env var (though FWIW `testing/data` is still not correct in the verification script, it's `arrow-testing/data` 🤷♂). Closes #6345 from nealrichardson/flight-testing-data and squashes the following commits: a29e88a <Krisztián Szűcs> factor out testing repository cloning df9ef25 <Neal Richardson> Move addition and fix lint e165d54 <Neal Richardson> Make sure macOS wheel verification has test data Lead-authored-by: Neal Richardson <[email protected]> Co-authored-by: Krisztián Szűcs <[email protected]> Signed-off-by: Krisztián Szűcs <[email protected]>
Member
|
Environment variable is OK but the name,
|
Member
Author
|
@kou filed an issue https://issues.apache.org/jira/browse/ARROW-7771 |
kszucs
added a commit
that referenced
this pull request
Feb 7, 2020
…tartable Executing the verification script can take quite some time, so creating a new environment in case if anything fails is time consuming. Let the script reuse the same build directory for source release verification. Need to export `TMPDIR` environment variable. @kou shall we use an argument instead? Closes #6344 from kszucs/restartable-verification and squashes the following commits: 6d4723d <Krisztián Szűcs> Support for restarting the release verification script Authored-by: Krisztián Szűcs <[email protected]> Signed-off-by: Krisztián Szűcs <[email protected]>
kszucs
added a commit
that referenced
this pull request
Feb 7, 2020
This addition follows the pattern of `test_source_distribution` (as it is in #6344). There are also two error message patches to make them consistent with everywhere else that references this env var (though FWIW `testing/data` is still not correct in the verification script, it's `arrow-testing/data` 🤷♂). Closes #6345 from nealrichardson/flight-testing-data and squashes the following commits: a29e88a <Krisztián Szűcs> factor out testing repository cloning df9ef25 <Neal Richardson> Move addition and fix lint e165d54 <Neal Richardson> Make sure macOS wheel verification has test data Lead-authored-by: Neal Richardson <[email protected]> Co-authored-by: Krisztián Szűcs <[email protected]> Signed-off-by: Krisztián Szűcs <[email protected]>
This was referenced Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing the verification script can take quite some time, so creating a new environment in case if anything fails is time consuming.
Let the script reuse the same build directory for source release verification.
Need to export
TMPDIRenvironment variable. @kou shall we use an argument instead?