Skip to content

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Jan 30, 2020

Additionally test agains dask's latest release not just the master revision.

@kszucs
Copy link
Member Author

kszucs commented Jan 30, 2020

@ursabot crossbow submit test-conda-python-3.7-dask-latest test-conda-python-3.8-dask-master

@kszucs
Copy link
Member Author

kszucs commented Jan 30, 2020

AMD64 Conda Crossbow Submit (#88781) builder has been succeeded.

Revision: 083221c

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-472

Task Status
test-conda-python-3.7-dask-latest CircleCI
test-conda-python-3.8-dask-master CircleCI

@github-actions
Copy link

@nealrichardson
Copy link
Member

This seems dangerous in the long-term. Is there a Jira for fixing the issue that requires the version pin (at which point we would remove this pin)?

@kszucs
Copy link
Member Author

kszucs commented Jan 30, 2020

@ursabot crossbow submit test-conda-python-3.7-dask-latest test-conda-python-3.8-dask-master

@kszucs
Copy link
Member Author

kszucs commented Jan 30, 2020

AMD64 Conda Crossbow Submit (#88806) builder has been succeeded.

Revision: b5cb40e

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-473

Task Status
test-conda-python-3.7-dask-latest CircleCI
test-conda-python-3.8-dask-master CircleCI

@kszucs
Copy link
Member Author

kszucs commented Jan 30, 2020

@nealrichardson the issue is between dask and pandas, we just pin the right pandas version to test dask arrow compatibility.

Copy link
Member Author

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kszucs kszucs closed this in 68c2f3c Feb 3, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dask already released a pandas1.0 compatible release a week ago (2.10, https://github.com/dask/dask/releases), so I am surprised this was needed. What was the failure we got?

COPY ci/scripts/install_dask.sh /arrow/ci/scripts/
RUN /arrow/ci/scripts/install_dask.sh ${dask}

# The Spark tests currently break with pandas >= 1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spark -> dask?

kszucs added a commit that referenced this pull request Feb 7, 2020
…ration test

Additionally test agains dask's latest release not just the master revision.

Closes #6326 from kszucs/dask-pandas-pin and squashes the following commits:

b5cb40e <Krisztián Szűcs> pin pandas depending on dask's version
083221c <Krisztián Szűcs> pin pandas in the dask integration test

Authored-by: Krisztián Szűcs <[email protected]>
Signed-off-by: Krisztián Szűcs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants