-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-7729: [Python][CI] Pin pandas version to 0.25 in the dask integration test #6326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ursabot crossbow submit test-conda-python-3.7-dask-latest test-conda-python-3.8-dask-master |
|
AMD64 Conda Crossbow Submit (#88781) builder has been succeeded. Revision: 083221c Submitted crossbow builds: ursa-labs/crossbow @ ursabot-472
|
|
This seems dangerous in the long-term. Is there a Jira for fixing the issue that requires the version pin (at which point we would remove this pin)? |
|
@ursabot crossbow submit test-conda-python-3.7-dask-latest test-conda-python-3.8-dask-master |
|
AMD64 Conda Crossbow Submit (#88806) builder has been succeeded. Revision: b5cb40e Submitted crossbow builds: ursa-labs/crossbow @ ursabot-473
|
|
@nealrichardson the issue is between dask and pandas, we just pin the right pandas version to test dask arrow compatibility. |
kszucs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dask already released a pandas1.0 compatible release a week ago (2.10, https://github.com/dask/dask/releases), so I am surprised this was needed. What was the failure we got?
| COPY ci/scripts/install_dask.sh /arrow/ci/scripts/ | ||
| RUN /arrow/ci/scripts/install_dask.sh ${dask} | ||
|
|
||
| # The Spark tests currently break with pandas >= 1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spark -> dask?
…ration test Additionally test agains dask's latest release not just the master revision. Closes #6326 from kszucs/dask-pandas-pin and squashes the following commits: b5cb40e <Krisztián Szűcs> pin pandas depending on dask's version 083221c <Krisztián Szűcs> pin pandas in the dask integration test Authored-by: Krisztián Szűcs <[email protected]> Signed-off-by: Krisztián Szűcs <[email protected]>
Additionally test agains dask's latest release not just the master revision.