Skip to content

ARROW-7726: [CI] [C++] Use boost binaries on Windows GHA build #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pitrou wants to merge 3 commits into from
Closed

ARROW-7726: [CI] [C++] Use boost binaries on Windows GHA build #6325

pitrou wants to merge 3 commits into from

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Jan 30, 2020 •
edited
Loading

The binaries are installed using Chocolatey, which takes a bit of time (it's a 2+GB install...), but less so than recompiling Boost from scratch during the CMake build.

[skip appveyor]

@github-actions
Copy link

github-actions bot commented Jan 30, 2020

https://issues.apache.org/jira/browse/ARROW-7726

@pitrou
Copy link
Member Author

pitrou commented Jan 30, 2020

Before: 25 min total (https://github.com/apache/arrow/runs/417128878)
After: 16 min total (https://github.com/apache/arrow/pull/6325/checks?check_run_id=417562708)

kou
kou reviewed Jan 30, 2020
View reviewed changes
.github/workflows/cpp.yml Outdated
Copy link
Member

@kou kou Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this step?

Copy link
Member Author

@pitrou pitrou Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's useful to have system info in CI builds.

.github/workflows/cpp.yml Outdated
Copy link
Member

@kou kou Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this when boost-msvc-14.1 is updated?
Can we detect this automatically?

Does this work?

diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index abc3b8f4d..4cccbdfd0 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -185,7 +185,11 @@ jobs:
           submodules: true
       - name: Build
         shell: bash
-        run: ci/scripts/cpp_build.sh $(pwd) $(pwd)/build
+        run: |
+          boost_root="$(echo /c/local/boost_* | head -n1)"
+          export BOOST_ROOT="c:\\local\\$(dirname ${boost_root})"
+          export BOOST_LIBRARYDIR="${BOOST_ROOT}\\lib64-msvc-14.1"
+          ci/scripts/cpp_build.sh $(pwd) $(pwd)/build
       - name: Test
         shell: bash
         run: ci/scripts/cpp_test.sh $(pwd) $(pwd)/build

Copy link
Member Author

@pitrou pitrou Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'll try it :-)

Copy link
Member Author

@pitrou pitrou Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this:

  export BOOST_ROOT="$(ls -1 /c/local/boost_* | tail -n1)"
  export BOOST_LIBRARYDIR="${BOOST_ROOT}\\lib64-msvc-14.1"
  echo "BOOST_ROOT: ${BOOST_ROOT}"

and I got:

BOOST_ROOT: tools

:-O

I don't want to spend time debugging this (especially as Github Actions seems a bit slow today), so I'm gonna revert the change.

Copy link
Member

@kou kou Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll take it over as a follow-up task.

@pitrou pitrou force-pushed the ARROW-7726-download-boost-gha branch from 9060c3e to acb9383 Compare February 3, 2020 15:04
@pitrou pitrou force-pushed the ARROW-7726-download-boost-gha branch from acb9383 to eb5db8f Compare February 3, 2020 15:32
kou
kou approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou closed this in 4b54997 Feb 3, 2020
@pitrou pitrou deleted the ARROW-7726-download-boost-gha branch February 4, 2020 00:15
@wesm
Copy link
Member

wesm commented Feb 4, 2020

I wonder why it's 2+GB, is it because of the static libraries I guess?

@pitrou
Copy link
Member Author

pitrou commented Feb 4, 2020

Not sure. I think it bundles all versions (debug, etc.) of the libraries.

kszucs pushed a commit that referenced this pull request Feb 7, 2020
@pitrou @kszucs
ARROW-7726: [CI] [C++] Use boost binaries on Windows GHA build
3f0c41a 
The binaries are installed using Chocolatey, which takes a bit of time (it's a 2+GB install...), but less so than recompiling Boost from scratch during the CMake build.

[skip appveyor]

Closes #6325 from pitrou/ARROW-7726-download-boost-gha and squashes the following commits:

e877622 <Antoine Pitrou> Revert "Try a more flexible way of finding Boost"
eb5db8f <Antoine Pitrou> Try a more flexible way of finding Boost
d570649 <Antoine Pitrou> ARROW-7726:   Use boost binaries on Windows GHA build

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@asfimport asfimport mentioned this pull request Feb 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@kszucs kszucs kszucs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou @wesm @kou @kszucs