Skip to content

ARROW-101: Fix java compiler warnings #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
laurentgo wants to merge 2 commits into from
Closed

ARROW-101: Fix java compiler warnings #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61bde83
[ARROW-101] Fix java compiler rawtypes warnings
laurentgo Apr 14, 2016
96ccc67
[ARROW-101] Fix java compiler resources warnings
laurentgo Apr 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions java/vector/src/main/java/org/apache/arrow/vector/ZeroVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import io.netty.buffer.ArrowBuf;

import java.util.Collections;
import java.util.Iterator;

import org.apache.arrow.memory.BufferAllocator;
Expand Down Expand Up @@ -109,8 +110,8 @@ public TransferPair getTransferPair(BufferAllocator allocator) {
// }

@Override
public Iterator iterator() {
return Iterators.emptyIterator();
public Iterator<ValueVector> iterator() {
return Collections.emptyIterator();
}

@Override
Expand Down
8 changes: 4 additions & 4 deletions java/vector/src/main/java/org/apache/arrow/vector/complex/impl/PromotableWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,16 +85,16 @@ private void setWriter(ValueVector v) {
state = State.SINGLE;
vector = v;
type = v.getField().getType().getMinorType();
Class writerClass = BasicTypeHelper
Class<?> writerClass = BasicTypeHelper
.getWriterImpl(v.getField().getType().getMinorType(), v.getField().getDataMode());
if (writerClass.equals(SingleListWriter.class)) {
writerClass = UnionListWriter.class;
}
Class vectorClass = BasicTypeHelper.getValueVectorClass(v.getField().getType().getMinorType(), v.getField()
Class<?> vectorClass = BasicTypeHelper.getValueVectorClass(v.getField().getType().getMinorType(), v.getField()
.getDataMode());
try {
Constructor constructor = null;
for (Constructor c : writerClass.getConstructors()) {
Constructor<?> constructor = null;
for (Constructor<?> c : writerClass.getConstructors()) {
if (c.getParameterTypes().length == 3) {
constructor = c;
}
Expand Down
2 changes: 1 addition & 1 deletion java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringArrayList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public boolean equals(Object obj) {
if (!(obj instanceof List)) {
return false;
}
List other = (List) obj;
List<?> other = (List<?>) obj;
return this.size() == other.size() && this.containsAll(other);
}

Expand Down
2 changes: 1 addition & 1 deletion java/vector/src/main/java/org/apache/arrow/vector/util/JsonStringHashMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public boolean equals(Object obj) {
if (!(obj instanceof Map)) {
return false;
}
Map other = (Map) obj;
Map<?, ?> other = (Map<?, ?>) obj;
if (this.size() != other.size()) {
return false;
}
Expand Down