Skip to content

ARROW-6435: [Python] Use pandas null coding consistently on List and Struct types #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wesm wants to merge 5 commits into from
Closed

ARROW-6435: [Python] Use pandas null coding consistently on List and Struct types #5302

wesm wants to merge 5 commits into from

Conversation

@wesm
Copy link
Member

@wesm wesm commented Sep 5, 2019 •
edited
Loading

also fixes ARROW-6434

wesm
wesm commented Sep 5, 2019
View reviewed changes
cpp/src/arrow/python/python_to_arrow.cc Outdated
Copy link
Member Author

@wesm wesm Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved code. Unchanged

cpp/src/arrow/python/python_to_arrow.cc Outdated
Copy link
Member Author

@wesm wesm Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved code

cpp/src/arrow/python/python_to_arrow.cc Outdated
Copy link
Member Author

@wesm wesm Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant changes

cpp/src/arrow/python/python_to_arrow.cc Outdated
Copy link
Member Author

@wesm wesm Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant changes

@wesm
Copy link
Member Author

wesm commented Sep 6, 2019

There's another failure here, that separately came up in #5299. I'll add some tests and close #5299

@wesm
Copy link
Member Author

wesm commented Sep 6, 2019

OK, the Dask integration tests are passing again. Checking HDFS

@wesm
Copy link
Member Author

wesm commented Sep 6, 2019

OK, HDFS docker-compose job passing also now

@kszucs
Copy link
Member

kszucs commented Sep 6, 2019

@ursabot crossbow test docker-hdfs-integration docker-dask-integration

@ursabot
Copy link

ursabot commented Sep 6, 2019

AMD64 Conda Crossbow (#59368) builder has been succeeded.

Revision: 68b84439a483e1bd31eb6fc339ef9afe82c73d8c

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-150

Task Status
docker-dask-integration CircleCI
docker-hdfs-integration CircleCI

@kszucs
Copy link
Member

kszucs commented Sep 6, 2019

@ursabot crossbow test docker-hdfs-integration

@ursabot
Copy link

ursabot commented Sep 6, 2019

AMD64 Conda Crossbow (#59373) builder has been succeeded.

Revision: 68b84439a483e1bd31eb6fc339ef9afe82c73d8c

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-155

Task Status
docker-hdfs-integration CircleCI

@kszucs
Copy link
Member

kszucs commented Sep 6, 2019

The HDFS build was cancelled, don't know why.

@wesm wesm mentioned this pull request Sep 6, 2019
Closed
@wesm
Copy link
Member Author

wesm commented Sep 6, 2019

Rebased this and fixed the conflict from #5299 (which should not have been merged)

@wesm
Copy link
Member Author

wesm commented Sep 6, 2019

+1

Travis CI: https://travis-ci.org/wesm/arrow/builds/581726782
Appveyor: https://ci.appveyor.com/project/wesm/arrow/builds/27234814

@wesm wesm closed this in e29e267 Sep 6, 2019
@wesm wesm deleted the ARROW-6435 branch September 6, 2019 16:23
This was referenced Sep 16, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wesm @kszucs @ursabot