ARROW-6194: [Java] Add non-static approach in DictionaryEncoder making it easy to extend and reuse #5055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o extend and reuse
Codecov Report
@@ Coverage Diff @@
## master #5055 +/- ##
==========================================
+ Coverage 87.59% 89.71% +2.12%
==========================================
Files 1009 670 -339
Lines 143898 99567 -44331
Branches 1418 0 -1418
==========================================
- Hits 126049 89329 -36720
+ Misses 17487 10238 -7249
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
emkornfield
reviewed
Aug 10, 2019
java/vector/src/main/java/org/apache/arrow/vector/dictionary/DictionaryEncoder.java
Show resolved
Hide resolved
tianchen92
changed the title
emkornfield
reviewed
Aug 11, 2019
java/vector/src/test/java/org/apache/arrow/vector/TestDictionaryVector.java
Show resolved
Hide resolved
Contributor
Author
|
@emkornfield PR has updated, would appreciate if you could take another look, thanks :) |
emkornfield
reviewed
Aug 13, 2019
| /** | ||
| * Build hash table with dictionary vector. | ||
| */ | ||
| public void ensureBuildTable() { |
Contributor
There was a problem hiding this comment.
why not put this in the constructor either in this class or in DictionaryEncoder?
Contributor
Author
There was a problem hiding this comment.
You are right, fixe now, thanks.
Contributor
|
+1, thank you. As noted on the mailing list please try to work with @liyafan82 to figure out the path forward on encoders in general. |
Contributor
Author
ok |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…g it easy to extend and reuse Related to [ARROW-6194](https://issues.apache.org/jira/browse/ARROW-6194). As discussed in apache#4994. Current static DictionaryEncoder has some limitation for extension and reuse. Slightly change the APIs and migrate static method to object based approach. Closes apache#5055 from tianchen92/ARROW-6194 and squashes the following commits: 2354c48 <tianchen> move build table logic to constructor 7b76cba <tianchen> add test 513f417 <tianchen> add static method back fb2d293 <tianchen> ARROW-6194: Make DictionaryEncoder non-static making it easy to extend and reuse Authored-by: tianchen <[email protected]> Signed-off-by: Micah Kornfield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6194.
As discussed in #4994.
Current static DictionaryEncoder has some limitation for extension and reuse.
Slightly change the APIs and migrate static method to object based approach.