GH-47713: [C++][FlightRPC] ODBC return number of result columns #48036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
force-pushed
the
gh-47713-sql-num-result-cols
branch
from
a940fec to
df78aae
Compare
alinaliBQ
commented
Nov 10, 2025
Comment on lines
86
to
88
| /** | ||
| * @brief Closes the cursor. This does _not_ un-prepare the statement or change | ||
| * bindings. |
Contributor
Author
There was a problem hiding this comment.
The other @brief usages will be changed in their respective PRs
alinaliBQ
changed the title
github-actions
bot
added
awaiting committer review
Contributor
Author
|
@lidavidm this draft PR is ready for review! Please have a look |
lidavidm
approved these changes
Nov 28, 2025
github-actions
bot
added
awaiting merge
alinaliBQ
force-pushed
the
gh-47713-sql-num-result-cols
branch
2 times, most recently
from
d4b91ec to
baaa1e8
Compare
Member
|
This needs to be rebased! |
Update docs Co-Authored-By: alinalibq <[email protected]>
alinaliBQ
force-pushed
the
gh-47713-sql-num-result-cols
branch
from
baaa1e8 to
a574826
Compare
Contributor
Author
|
Ty for the heads up, rebased |
lidavidm
approved these changes
Dec 8, 2025
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2a3c5db. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 23 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Implement ODBC to return the number of result columns
What changes are included in this PR?
Are these changes tested?
Tested locally on MSVC
Are there any user-facing changes?
N/A