GH-47713: [C++][FlightRPC] ODBC SQLMoreResults implementation #48035
Conversation
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
force-pushed
the
gh-47713-sql-more-results
branch
from
060321b to
1791d58
Compare
| class StatementMockTest : public FlightSQLODBCMockTestBase {}; | ||
| class StatementRemoteTest : public FlightSQLODBCRemoteTestBase {}; | ||
| using TestTypes = ::testing::Types<StatementMockTest, StatementRemoteTest>; | ||
| TYPED_TEST_SUITE(StatementTest, TestTypes); |
There was a problem hiding this comment.
2 tests TestSQLMoreResultsNoData and TestSQLMoreResultsInvalidFunctionSequence are added in this PR.
alinaliBQ
changed the title
github-actions
bot
added
awaiting committer review
|
@lidavidm this draft PR is ready for review! Please have a look |
alinaliBQ
force-pushed
the
gh-47713-sql-more-results
branch
2 times, most recently
from
5f90811 to
e841e88
Compare
Nit updates Co-Authored-By: alinalibq <[email protected]>
alinaliBQ
force-pushed
the
gh-47713-sql-more-results
branch
from
e841e88 to
f1a2076
Compare
github-actions
bot
added
awaiting merge
|
@alinaliBQ one note for the future, do you mind making one issue per PR? It seems several of these PRs were connected to one issue, which isn't a big deal, but we generally try to have one issue per PR. Organizationally you could make a top-level issue and use GitHub's sub issues if that helps keep track of things. Thanks! |
|
@lidavidm Yes I can have 1 issue per PR in future. Your suggestion of using a top-level issue makes sense, just that I have tried that before and I don't think I have access since I am not a maintainer. I will mention parent issues in the child issue tickets. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f8e40da. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
2 participants
Rationale for this change
Implement SQLMoreResults for fetching more results. Arrow protocol doesn't support multiple result sets, so
no datais returned by default in SQLMoreResults.What changes are included in this PR?
Are these changes tested?
Tested on local MSVC
Are there any user-facing changes?
N/A