Skip to content

Conversation

@alinaliBQ
Copy link
Contributor

@alinaliBQ alinaliBQ commented Oct 31, 2025

Rationale for this change

Implement SQLNativeSQL to return the same string as input as ODBC doesn't support

What changes are included in this PR?

  • SQLNativeSQL implementation

Are these changes tested?

  • Will be tested in CI when PR is ready for review

Are there any user-facing changes?

N/A

@github-actions
Copy link

⚠️ GitHub issue #47723 has been automatically assigned in GitHub to PR creator.

@alinaliBQ
Copy link
Contributor Author

@lidavidm this draft PR is ready for review! Please have a look

@justing-bq justing-bq force-pushed the gh-47723-sql-native-sql branch from f88d998 to fb5bdf7 Compare November 14, 2025 20:12
@alinaliBQ alinaliBQ marked this pull request as ready for review November 14, 2025 20:28
@alinaliBQ alinaliBQ requested a review from lidavidm as a code owner November 14, 2025 20:28
@justing-bq justing-bq force-pushed the gh-47723-sql-native-sql branch from fb5bdf7 to ed82791 Compare November 17, 2025 22:39
@alinaliBQ alinaliBQ force-pushed the gh-47723-sql-native-sql branch from ed82791 to e958ed1 Compare December 1, 2025 22:01
@justing-bq justing-bq force-pushed the gh-47723-sql-native-sql branch from e958ed1 to bc6881b Compare December 2, 2025 21:49
@lidavidm lidavidm merged commit 79695c2 into apache:main Dec 3, 2025
44 of 45 checks passed
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Dec 3, 2025
@justing-bq justing-bq deleted the gh-47723-sql-native-sql branch December 3, 2025 18:26
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 79695c2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants