GH-47809: [CI][Release] Fix Windows verification job trying to install patch from conda #47810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…install patch from conda
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@github-actions crossbow submit conda verify-rc-source-* |
|
Revision: 71579cc Submitted crossbow builds: ursacomputing/crossbow @ actions-e9d2219c05
|
2 tasks
Member
Author
|
None of the CI failures are related, they are already happening on our nightlies on main (not happening on the maintenance branch). |
pitrou
approved these changes
Oct 14, 2025
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1, thank you. I am surprised that conda-forge does not package patch for Windows. @h-vetinari Is that expected?
raulcd
added a commit
that referenced
this pull request
Oct 14, 2025
…l patch from conda (#47810) ### Rationale for this change Our verify-rc-source Windows job is failing due to patch not being available for Windows. ### What changes are included in this PR? Move patch requirement from `conda_env_cpp.txt` to `conda_env_unix.txt` ### Are these changes tested? Yes via CI and archery. ### Are there any user-facing changes? No * GitHub Issue: #47809 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Contributor
There's no native |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2a5ad38. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
…install patch from conda (apache#47810) ### Rationale for this change Our verify-rc-source Windows job is failing due to patch not being available for Windows. ### What changes are included in this PR? Move patch requirement from `conda_env_cpp.txt` to `conda_env_unix.txt` ### Are these changes tested? Yes via CI and archery. ### Are there any user-facing changes? No * GitHub Issue: apache#47809 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Our verify-rc-source Windows job is failing due to patch not being available for Windows.
What changes are included in this PR?
Move patch requirement from
conda_env_cpp.txttoconda_env_unix.txtAre these changes tested?
Yes via CI and archery.
Are there any user-facing changes?
No