GH-47708: [C++][FlightRPC] Connection Attribute Support for ODBC #47772
+395
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
lidavidm
reviewed
Oct 10, 2025
github-actions
bot
added
awaiting changes
kou
reviewed
Oct 10, 2025
|
|
||
| #ifdef SQL_ATTR_ASYNC_DBC_EVENT | ||
| TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) { | ||
| this->Connect(); |
Member
There was a problem hiding this comment.
SetUp() as David commented in other PR?
Contributor
Author
There was a problem hiding this comment.
removed this->Connect() from tests. we will move it to SetUp
Member
|
Could you create new draft PRs after you complete other draft PRs to reflect comments in other draft PRs? |
Contributor
Author
alinaliBQ
force-pushed
the
gh-47708-sql-connect-attr
branch
from
af5de2e to
e8c404c
Compare
alinaliBQ
commented
Oct 21, 2025
|
|
||
| #ifdef SQL_ATTR_ASYNC_DBC_EVENT | ||
| TYPED_TEST(FlightSQLODBCTestBase, TestSQLSetConnectAttrAsyncDbcEventUnsupported) { | ||
| this->Connect(); |
Contributor
Author
There was a problem hiding this comment.
removed this->Connect() from tests. we will move it to SetUp
github-actions
bot
added
awaiting review
alinaliBQ
force-pushed
the
gh-47708-sql-connect-attr
branch
from
e8c404c to
c6c5af9
Compare
alinaliBQ
commented
Oct 22, 2025
Contributor
Author
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
Rebased on top of master
lidavidm
approved these changes
Oct 23, 2025
| out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize(); | ||
| std::string out_connection_string = | ||
| ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len)); | ||
| EXPECT_TRUE(!out_connection_string.empty()); |
github-actions
bot
added
awaiting merge
alinaliBQ
commented
Oct 23, 2025
| out_str_len /= arrow::flight::sql::odbc::GetSqlWCharSize(); | ||
| std::string out_connection_string = | ||
| ODBC::SqlWcharToString(out_str, static_cast<SQLSMALLINT>(out_str_len)); | ||
| EXPECT_TRUE(!out_connection_string.empty()); |
alinaliBQ
force-pushed
the
gh-47708-sql-connect-attr
branch
from
c6c5af9 to
2332bda
Compare
lidavidm
approved these changes
Oct 31, 2025
alinaliBQ
force-pushed
the
gh-47708-sql-connect-attr
branch
from
2332bda to
e5705e7
Compare
lidavidm
approved these changes
Nov 28, 2025
Member
|
@alinaliBQ can you resolve conflicts? |
Use `EXPECT_FALSE` Remove `using List` Rebase from `master` Work on code review comments Add tests for connection attribute Co-Authored-By: justing-bq <[email protected]> Co-Authored-By: alinalibq <[email protected]>
alinaliBQ
force-pushed
the
gh-47708-sql-connect-attr
branch
from
e5705e7 to
23b8689
Compare
Contributor
Author
|
@lidavidm Thank you for the ping, rebased and resolved conflict |
lidavidm
approved these changes
Nov 30, 2025
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 95cdc0c. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add connection attribute support for ODBC driver.
What changes are included in this PR?
SQLGetConnectAttrandSQLSetConnectAttrto get and set connection attributesAre these changes tested?
Tested on local MSVC
Are there any user-facing changes?
No