GH-47748: [C++][Dataset] Fix link error on macOS #47749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
raulcd
reviewed
Oct 8, 2025
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
This is beyond my comprehension, but is this because of a change we have introduced recently?
I am happy for this to be merged, just trying to understand :)
github-actions
bot
added
awaiting changes
Member
Author
|
No... It was introduced in 2022...: #13911 BTW, this was not enough: https://github.com/kou/arrow-java/actions/runs/18334827827/job/52217628114#step:12:2474 It seems that we need the Network framework too. |
github-actions
bot
added
awaiting change review
Member
Author
|
https://github.com/kou/arrow-java/actions/runs/18334827827/job/52321140360#step:12:2475
|
kou
changed the title
Member
Author
|
Fixed: https://github.com/kou/arrow-java/actions/runs/18370527401/job/52334724160#step:12:2489 This is ready. This error is another problem that should be fixed in apache/arrow-java: https://github.com/kou/arrow-java/actions/runs/18370527401/job/52334724160#step:12:2535 |
raulcd
reviewed
Oct 10, 2025
| compute/kernels/scalar_temporal_binary.cc | ||
| compute/kernels/scalar_temporal_unary.cc | ||
| compute/kernels/scalar_validity.cc | ||
| compute/kernels/temporal_internal.cc |
Member
There was a problem hiding this comment.
that's a good find! Thanks for the fix!
Does this kernel has to be part of libarrow core, can't it be part of libarrow_compute instead? Maybe @rok
We should try to keep on libarrow only the core kernels (like cast, etcetera) that are required for libarrow.
Member
Author
There was a problem hiding this comment.
I think that we need this in libarrow.so because
Member
There was a problem hiding this comment.
ok, let's merge this and maybe we could explore whether this is "really necessary" as a core kernel on a separate issue? @rok ?
github-actions
bot
added
awaiting changes
raulcd
approved these changes
Oct 10, 2025
raulcd
pushed a commit
that referenced
this pull request
Oct 10, 2025
### Rationale for this change There are link errors with build options for JNI on macOS. ### What changes are included in this PR? `ARROW_BUNDLED_STATIC_LIBS` has CMake target names defined in Apache Arrow not `find_package()`-ed target names. So we should use `aws-c-common` not `AWS::aws-c-common`. Recent aws-c-common or something use the Network framework. So add `Network` to `Arrow::arrow_bundled_dependencies` dependencies. Don't use `compute/kernels/temporal_internal.cc` in `libarrow.dylib` and `libarrow_compute.dylib` to avoid duplicated symbols error. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #47748 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 7700dd4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
### Rationale for this change There are link errors with build options for JNI on macOS. ### What changes are included in this PR? `ARROW_BUNDLED_STATIC_LIBS` has CMake target names defined in Apache Arrow not `find_package()`-ed target names. So we should use `aws-c-common` not `AWS::aws-c-common`. Recent aws-c-common or something use the Network framework. So add `Network` to `Arrow::arrow_bundled_dependencies` dependencies. Don't use `compute/kernels/temporal_internal.cc` in `libarrow.dylib` and `libarrow_compute.dylib` to avoid duplicated symbols error. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#47748 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There are link errors with build options for JNI on macOS.
What changes are included in this PR?
ARROW_BUNDLED_STATIC_LIBShas CMake target names defined in Apache Arrow notfind_package()-ed target names. So we should useaws-c-commonnotAWS::aws-c-common.Recent aws-c-common or something use the Network framework. So add
NetworktoArrow::arrow_bundled_dependenciesdependencies.Don't use
compute/kernels/temporal_internal.ccinlibarrow.dylibandlibarrow_compute.dylibto avoid duplicated symbols error.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
ArrowConfig.cmakemisses some system dependencies on macOS #47748